fixes #595 mutex leak and other minor errors in TCP

fixes #596 POSIX IPC should move away from pipedesc/epdesc
fixes #598 TLS and TCP listeners could support NNG_OPT_LOCADDR
fixes #594 Windows IPC should use "new style" win_io code.
fixes #597 macOS could support PEER PID

This large change set cleans up the IPC support on Windows and
POSIX.  This has the beneficial impact of significantly reducing
the complexity of the code, reducing locking, increasing
concurrency (multiple dial and accepts can be outstanding now),
reducing context switches (we complete thins synchronously now).

While here we have added some missing option support, and fixed a
few more bugs that we found in the TCP code changes from last week.

1 files changed, 0 insertions, 250 deletions

diff --git a/src/platform/posix/posix_ipc.c b/src/platform/posix/posix_ipc.c
deleted file mode 100644
index 5ba3c8fb..00000000
--- a/src/platform/posix/posix_ipc.c
+++ /dev/null
@@ -1,250 +0,0 @@
-//
-// Copyright 2018 Staysail Systems, Inc. <info@staysail.tech>
-// Copyright 2018 Capitar IT Group BV <info@capitar.com>
-//
-// This software is supplied under the terms of the MIT License, a
-// copy of which should be located in the distribution where this
-// file was obtained (LICENSE.txt).  A copy of the license may also be
-// found online at https://opensource.org/licenses/MIT.
-//
-
-#include "core/nng_impl.h"
-
-#ifdef NNG_PLATFORM_POSIX
-#include "platform/posix/posix_aio.h"
-
-#include <errno.h>
-#include <fcntl.h>
-#include <netdb.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <sys/socket.h>
-#include <sys/types.h>
-#include <sys/uio.h>
-#include <sys/un.h>
-#include <unistd.h>
-
-#ifdef SOCK_CLOEXEC
-#define NNI_STREAM_SOCKTYPE (SOCK_STREAM | SOCK_CLOEXEC)
-#else
-#define NNI_STREAM_SOCKTYPE SOCK_STREAM
-#endif
-
-// Solaris/SunOS systems define this, which collides with our symbol
-// names.  Just undefine it now.
-#ifdef sun
-#undef sun
-#endif
-
-static int nni_plat_ipc_remove_stale(const char *path);
-
-// We alias nni_posix_pipedesc to nni_plat_ipc_pipe.
-// We alias nni_posix_epdesc to nni_plat_ipc_ep.
-
-int
-nni_plat_ipc_ep_init(nni_plat_ipc_ep **epp, const nni_sockaddr *sa, int mode)
-{
-	nni_posix_epdesc * ed;
-	int                rv;
-	struct sockaddr_un sun;
-
-	if ((rv = nni_posix_epdesc_init(&ed, mode)) != 0) {
-		return (rv);
-	}
-	switch (mode) {
-	case NNI_EP_MODE_DIAL:
-		nni_posix_nn2sockaddr(&sun, sa);
-		nni_posix_epdesc_set_remote(ed, &sun, sizeof(sun));
-		break;
-	case NNI_EP_MODE_LISTEN:
-
-		if ((rv = nni_plat_ipc_remove_stale(sa->s_ipc.sa_path)) != 0) {
-			return (rv);
-		}
-
-		nni_posix_nn2sockaddr(&sun, sa);
-		nni_posix_epdesc_set_local(ed, &sun, sizeof(sun));
-		break;
-	default:
-		nni_posix_epdesc_fini(ed);
-		return (NNG_EINVAL);
-	}
-
-	*epp = (void *) ed;
-	return (0);
-}
-
-void
-nni_plat_ipc_ep_fini(nni_plat_ipc_ep *ep)
-{
-	nni_posix_epdesc_fini((void *) ep);
-}
-
-void
-nni_plat_ipc_ep_close(nni_plat_ipc_ep *ep)
-{
-	nni_posix_epdesc_close((void *) ep);
-}
-
-int
-nni_plat_ipc_ep_set_permissions(nni_plat_ipc_ep *ep, uint32_t bits)
-{
-	return (nni_posix_epdesc_set_permissions((void *) ep, (mode_t) bits));
-}
-
-int
-nni_plat_ipc_ep_set_security_descriptor(nni_plat_ipc_ep *ep, void *attr)
-{
-	NNI_ARG_UNUSED(ep);
-	NNI_ARG_UNUSED(attr);
-	return (NNG_ENOTSUP);
-}
-
-// UNIX DOMAIN SOCKETS -- these have names in the file namespace.
-// We are going to check to see if there was a name already there.
-// If there was, and nothing is listening (ECONNREFUSED), then we
-// will just try to cleanup the old socket.  Note that this is not
-// perfect in all scenarios, so use this with caution.
-static int
-nni_plat_ipc_remove_stale(const char *path)
-{
-	int                fd;
-	struct sockaddr_un sun;
-	size_t             sz;
-
-	sun.sun_family = AF_UNIX;
-	sz             = sizeof(sun.sun_path);
-
-	if (nni_strlcpy(sun.sun_path, path, sz) >= sz) {
-		return (NNG_EADDRINVAL);
-	}
-
-	if ((fd = socket(AF_UNIX, NNI_STREAM_SOCKTYPE, 0)) < 0) {
-		return (nni_plat_errno(errno));
-	}
-
-	// There is an assumption here that connect() returns immediately
-	// (even when non-blocking) when a server is absent.  This seems
-	// to be true for the platforms we've tried.  If it doesn't work,
-	// then the cleanup will fail.  As this is supposed to be an
-	// exceptional case, don't worry.
-	(void) fcntl(fd, F_SETFL, O_NONBLOCK);
-	if (connect(fd, (void *) &sun, sizeof(sun)) < 0) {
-		if (errno == ECONNREFUSED) {
-			(void) unlink(path);
-		}
-	}
-	(void) close(fd);
-	return (0);
-}
-
-int
-nni_plat_ipc_ep_listen(nni_plat_ipc_ep *ep)
-{
-	nni_posix_epdesc *ed = (void *) ep;
-
-	return (nni_posix_epdesc_listen(ed));
-}
-
-void
-nni_plat_ipc_ep_connect(nni_plat_ipc_ep *ep, nni_aio *aio)
-{
-	nni_posix_epdesc_connect((void *) ep, aio);
-}
-
-void
-nni_plat_ipc_ep_accept(nni_plat_ipc_ep *ep, nni_aio *aio)
-{
-	nni_posix_epdesc_accept((void *) ep, aio);
-}
-
-void
-nni_plat_ipc_pipe_fini(nni_plat_ipc_pipe *p)
-{
-	nni_posix_pipedesc_fini((void *) p);
-}
-
-void
-nni_plat_ipc_pipe_close(nni_plat_ipc_pipe *p)
-{
-	nni_posix_pipedesc_close((void *) p);
-}
-
-void
-nni_plat_ipc_pipe_send(nni_plat_ipc_pipe *p, nni_aio *aio)
-{
-	nni_posix_pipedesc_send((void *) p, aio);
-}
-
-void
-nni_plat_ipc_pipe_recv(nni_plat_ipc_pipe *p, nni_aio *aio)
-{
-	nni_posix_pipedesc_recv((void *) p, aio);
-}
-
-int
-nni_plat_ipc_pipe_get_peer_uid(nni_plat_ipc_pipe *p, uint64_t *uid)
-{
-	int      rv;
-	uint64_t ignore;
-
-	if ((rv = nni_posix_pipedesc_get_peerid(
-	         (void *) p, uid, &ignore, &ignore, &ignore)) != 0) {
-		return (rv);
-	}
-	return (0);
-}
-
-int
-nni_plat_ipc_pipe_get_peer_gid(nni_plat_ipc_pipe *p, uint64_t *gid)
-{
-	int      rv;
-	uint64_t ignore;
-
-	if ((rv = nni_posix_pipedesc_get_peerid(
-	         (void *) p, &ignore, gid, &ignore, &ignore)) != 0) {
-		return (rv);
-	}
-	return (0);
-}
-
-int
-nni_plat_ipc_pipe_get_peer_zoneid(nni_plat_ipc_pipe *p, uint64_t *zid)
-{
-	int      rv;
-	uint64_t ignore;
-	uint64_t id;
-
-	if ((rv = nni_posix_pipedesc_get_peerid(
-	         (void *) p, &ignore, &ignore, &ignore, &id)) != 0) {
-		return (rv);
-	}
-	if (id == (uint64_t) -1) {
-		// NB: -1 is not a legal zone id (illumos/Solaris)
-		return (NNG_ENOTSUP);
-	}
-	*zid = id;
-	return (0);
-}
-
-int
-nni_plat_ipc_pipe_get_peer_pid(nni_plat_ipc_pipe *p, uint64_t *pid)
-{
-	int      rv;
-	uint64_t ignore;
-	uint64_t id;
-
-	if ((rv = nni_posix_pipedesc_get_peerid(
-	         (void *) p, &ignore, &ignore, &id, &ignore)) != 0) {
-		return (rv);
-	}
-	if (id == (uint64_t) -1) {
-		// NB: -1 is not a legal process id
-		return (NNG_ENOTSUP);
-	}
-	*pid = id;
-	return (0);
-}
-
-#endif // NNG_PLATFORM_POSIX