fixes #289 nng_sockaddr could just be a union

fixes #290 sockaddr improvements

15 files changed, 124 insertions, 124 deletions

diff --git a/src/core/defs.h b/src/core/defs.h
index c449aa32..0f38b9cf 100644
--- a/src/core/defs.h
+++ b/src/core/defs.h
@@ -31,13 +31,13 @@
 
 // These types are common but have names shared with user space.
 // Internal code should use these names when possible.
-typedef struct nng_msg      nni_msg;
-typedef struct nng_sockaddr nni_sockaddr;
-typedef struct nng_event    nni_event;
-typedef struct nng_notify   nni_notify;
-typedef struct nng_url      nni_url;
-typedef struct nng_iov      nni_iov;
-typedef struct nng_aio      nni_aio;
+typedef nng_msg           nni_msg;
+typedef nng_sockaddr      nni_sockaddr;
+typedef nng_url           nni_url;
+typedef nng_iov           nni_iov;
+typedef nng_aio           nni_aio;
+typedef struct nng_event  nni_event;
+typedef struct nng_notify nni_notify;
 
 // These are our own names.
 typedef struct nni_socket           nni_sock;
diff --git a/src/nng.h b/src/nng.h
index b7adee93..a581d434 100644
--- a/src/nng.h
+++ b/src/nng.h
@@ -619,13 +619,18 @@ enum nng_errno_enum {
 // sockaddr, but we have our own to cope with our unique families, etc.
 // The details of this structure are directly exposed to applications.
 // These structures can be obtained via property lookups, etc.
+struct nng_sockaddr_inproc {
+	uint16_t sa_family;
+	char     sa_name[NNG_MAXADDRLEN];
+};
+typedef struct nng_sockaddr_inproc nng_sockaddr_inproc;
+
 struct nng_sockaddr_path {
 	uint16_t sa_family;
 	char     sa_path[NNG_MAXADDRLEN];
 };
 typedef struct nng_sockaddr_path nng_sockaddr_path;
 typedef struct nng_sockaddr_path nng_sockaddr_ipc;
-typedef struct nng_sockaddr_path nng_sockaddr_inproc;
 
 struct nng_sockaddr_in6 {
 	uint16_t sa_family;
@@ -654,15 +659,13 @@ typedef struct nng_sockaddr_in nng_sockaddr_udp;
 typedef struct nng_sockaddr_in nng_sockaddr_tcp;
 typedef struct nng_sockaddr_zt nng_sockaddr_zt;
 
-typedef struct nng_sockaddr {
-	union {
-		uint16_t            s_family;
-		nng_sockaddr_path   s_path;
-		nng_sockaddr_inproc s_inproc;
-		nng_sockaddr_in6    s_in6;
-		nng_sockaddr_in     s_in;
-		nng_sockaddr_zt     s_zt;
-	} s_un;
+typedef union nng_sockaddr {
+	uint16_t            s_family;
+	nng_sockaddr_ipc    s_ipc;
+	nng_sockaddr_inproc s_inproc;
+	nng_sockaddr_in6    s_in6;
+	nng_sockaddr_in     s_in;
+	nng_sockaddr_zt     s_zt;
 } nng_sockaddr;
 
 enum nng_sockaddr_family {
diff --git a/src/platform/posix/posix_ipc.c b/src/platform/posix/posix_ipc.c
index cd9da243..f7cfc0db 100644
--- a/src/platform/posix/posix_ipc.c
+++ b/src/platform/posix/posix_ipc.c
@@ -59,8 +59,7 @@ nni_plat_ipc_ep_init(nni_plat_ipc_ep **epp, const nni_sockaddr *sa, int mode)
 		break;
 	case NNI_EP_MODE_LISTEN:
 
-		if ((rv = nni_plat_ipc_remove_stale(
-		         sa->s_un.s_path.sa_path)) != 0) {
+		if ((rv = nni_plat_ipc_remove_stale(sa->s_ipc.sa_path)) != 0) {
 			return (rv);
 		}
 
diff --git a/src/platform/posix/posix_resolv_gai.c b/src/platform/posix/posix_resolv_gai.c
index f2f8a9fc..496fb97b 100644
--- a/src/platform/posix/posix_resolv_gai.c
+++ b/src/platform/posix/posix_resolv_gai.c
@@ -171,19 +171,18 @@ nni_posix_resolv_task(void *arg)
 
 		switch (probe->ai_addr->sa_family) {
 		case AF_INET:
-			rv                      = 0;
-			sin                     = (void *) probe->ai_addr;
-			sa->s_un.s_in.sa_family = NNG_AF_INET;
-			sa->s_un.s_in.sa_port   = sin->sin_port;
-			sa->s_un.s_in.sa_addr   = sin->sin_addr.s_addr;
+			rv                 = 0;
+			sin                = (void *) probe->ai_addr;
+			sa->s_in.sa_family = NNG_AF_INET;
+			sa->s_in.sa_port   = sin->sin_port;
+			sa->s_in.sa_addr   = sin->sin_addr.s_addr;
 			break;
 		case AF_INET6:
-			rv                       = 0;
-			sin6                     = (void *) probe->ai_addr;
-			sa->s_un.s_in6.sa_family = NNG_AF_INET6;
-			sa->s_un.s_in6.sa_port   = sin6->sin6_port;
-			memcpy(sa->s_un.s_in6.sa_addr, sin6->sin6_addr.s6_addr,
-			    16);
+			rv                  = 0;
+			sin6                = (void *) probe->ai_addr;
+			sa->s_in6.sa_family = NNG_AF_INET6;
+			sa->s_in6.sa_port   = sin6->sin6_port;
+			memcpy(sa->s_in6.sa_addr, sin6->sin6_addr.s6_addr, 16);
 			break;
 		}
 	}
diff --git a/src/platform/posix/posix_sockaddr.c b/src/platform/posix/posix_sockaddr.c
index e9691d91..ba088ed9 100644
--- a/src/platform/posix/posix_sockaddr.c
+++ b/src/platform/posix/posix_sockaddr.c
@@ -36,10 +36,10 @@ nni_posix_nn2sockaddr(void *sa, const nni_sockaddr *na)
 	if ((sa == NULL) || (na == NULL)) {
 		return (0);
 	}
-	switch (na->s_un.s_family) {
+	switch (na->s_family) {
 	case NNG_AF_INET:
 		sin  = (void *) sa;
-		nsin = &na->s_un.s_in;
+		nsin = &na->s_in;
 		memset(sin, 0, sizeof(*sin));
 		sin->sin_family      = PF_INET;
 		sin->sin_port        = nsin->sa_port;
@@ -48,7 +48,7 @@ nni_posix_nn2sockaddr(void *sa, const nni_sockaddr *na)
 
 	case NNG_AF_INET6:
 		sin6  = (void *) sa;
-		nsin6 = &na->s_un.s_in6;
+		nsin6 = &na->s_in6;
 		memset(sin6, 0, sizeof(*sin6));
 #ifdef SIN6_LEN
 		sin6->sin6_len = sizeof(*sin6);
@@ -60,7 +60,7 @@ nni_posix_nn2sockaddr(void *sa, const nni_sockaddr *na)
 
 	case NNG_AF_IPC:
 		spath  = (void *) sa;
-		nspath = &na->s_un.s_path;
+		nspath = &na->s_ipc;
 		memset(spath, 0, sizeof(*spath));
 		// Make sure that the path fits!
 		sz = sizeof(spath->sun_path);
@@ -89,21 +89,21 @@ nni_posix_sockaddr2nn(nni_sockaddr *na, const void *sa)
 	switch (((struct sockaddr *) sa)->sa_family) {
 	case AF_INET:
 		sin             = (void *) sa;
-		nsin            = &na->s_un.s_in;
+		nsin            = &na->s_in;
 		nsin->sa_family = NNG_AF_INET;
 		nsin->sa_port   = sin->sin_port;
 		nsin->sa_addr   = sin->sin_addr.s_addr;
 		break;
 	case AF_INET6:
 		sin6             = (void *) sa;
-		nsin6            = &na->s_un.s_in6;
+		nsin6            = &na->s_in6;
 		nsin6->sa_family = NNG_AF_INET6;
 		nsin6->sa_port   = sin6->sin6_port;
 		memcpy(nsin6->sa_addr, sin6->sin6_addr.s6_addr, 16);
 		break;
 	case AF_UNIX:
 		spath             = (void *) sa;
-		nspath            = &na->s_un.s_path;
+		nspath            = &na->s_ipc;
 		nspath->sa_family = NNG_AF_IPC;
 		(void) snprintf(nspath->sa_path, sizeof(nspath->sa_path), "%s",
 		    spath->sun_path);
diff --git a/src/platform/posix/posix_tcp.c b/src/platform/posix/posix_tcp.c
index 8a6fe9d1..9caa157f 100644
--- a/src/platform/posix/posix_tcp.c
+++ b/src/platform/posix/posix_tcp.c
@@ -40,11 +40,11 @@ nni_plat_tcp_ep_init(nni_plat_tcp_ep **epp, const nni_sockaddr *lsa,
 		return (rv);
 	}
 
-	if ((rsa != NULL) && (rsa->s_un.s_family != NNG_AF_UNSPEC)) {
+	if ((rsa != NULL) && (rsa->s_family != NNG_AF_UNSPEC)) {
 		len = nni_posix_nn2sockaddr((void *) &ss, rsa);
 		nni_posix_epdesc_set_remote(ed, &ss, len);
 	}
-	if ((lsa != NULL) && (lsa->s_un.s_family != NNG_AF_UNSPEC)) {
+	if ((lsa != NULL) && (lsa->s_family != NNG_AF_UNSPEC)) {
 		len = nni_posix_nn2sockaddr((void *) &ss, lsa);
 		nni_posix_epdesc_set_local(ed, &ss, len);
 	}
@@ -130,15 +130,15 @@ nni_plat_tcp_ntop(const nni_sockaddr *sa, char *ipstr, char *portstr)
 	const void *ap;
 	uint16_t    port;
 	int         af;
-	switch (sa->s_un.s_family) {
+	switch (sa->s_family) {
 	case NNG_AF_INET:
-		ap   = &sa->s_un.s_in.sa_addr;
-		port = sa->s_un.s_in.sa_port;
+		ap   = &sa->s_in.sa_addr;
+		port = sa->s_in.sa_port;
 		af   = AF_INET;
 		break;
 	case NNG_AF_INET6:
-		ap   = &sa->s_un.s_in6.sa_addr;
-		port = sa->s_un.s_in6.sa_port;
+		ap   = &sa->s_in6.sa_addr;
+		port = sa->s_in6.sa_port;
 		af   = AF_INET6;
 		break;
 	default:
diff --git a/src/platform/windows/win_ipc.c b/src/platform/windows/win_ipc.c
index 84afbaa5..5843917c 100644
--- a/src/platform/windows/win_ipc.c
+++ b/src/platform/windows/win_ipc.c
@@ -193,7 +193,7 @@ nni_plat_ipc_ep_init(nni_plat_ipc_ep **epp, const nni_sockaddr *sa, int mode)
 	const char *     path;
 	nni_plat_ipc_ep *ep;
 
-	path = sa->s_un.s_path.sa_path;
+	path = sa->s_ipc.sa_path;
 	if (nni_strnlen(path, NNG_MAXADDRLEN) >= NNG_MAXADDRLEN) {
 		return (NNG_EINVAL);
 	}
diff --git a/src/platform/windows/win_resolv.c b/src/platform/windows/win_resolv.c
index 6ee55d16..d07b4fd5 100644
--- a/src/platform/windows/win_resolv.c
+++ b/src/platform/windows/win_resolv.c
@@ -1,5 +1,6 @@
 //
-// Copyright 2017 Garrett D'Amore <garrett@damore.org>
+// Copyright 2018 Staysail Systems, Inc. <info@staysail.tech>
+// Copyright 2018 Capitar IT Group BV <info@capitar.com>
 //
 // This software is supplied under the terms of the MIT License, a
 // copy of which should be located in the distribution where this
@@ -145,19 +146,18 @@ nni_win_resolv_task(void *arg)
 
 		switch (probe->ai_addr->sa_family) {
 		case AF_INET:
-			rv                      = 0;
-			sin                     = (void *) probe->ai_addr;
-			sa->s_un.s_in.sa_family = NNG_AF_INET;
-			sa->s_un.s_in.sa_port   = sin->sin_port;
-			sa->s_un.s_in.sa_addr   = sin->sin_addr.s_addr;
+			rv                 = 0;
+			sin                = (void *) probe->ai_addr;
+			sa->s_in.sa_family = NNG_AF_INET;
+			sa->s_in.sa_port   = sin->sin_port;
+			sa->s_in.sa_addr   = sin->sin_addr.s_addr;
 			break;
 		case AF_INET6:
-			rv                       = 0;
-			sin6                     = (void *) probe->ai_addr;
-			sa->s_un.s_in6.sa_family = NNG_AF_INET6;
-			sa->s_un.s_in6.sa_port   = sin6->sin6_port;
-			memcpy(sa->s_un.s_in6.sa_addr, sin6->sin6_addr.s6_addr,
-			    16);
+			rv                  = 0;
+			sin6                = (void *) probe->ai_addr;
+			sa->s_in6.sa_family = NNG_AF_INET6;
+			sa->s_in6.sa_port   = sin6->sin6_port;
+			memcpy(sa->s_in6.sa_addr, sin6->sin6_addr.s6_addr, 16);
 			break;
 		}
 	}
diff --git a/src/platform/windows/win_sockaddr.c b/src/platform/windows/win_sockaddr.c
index f66542c6..141a1ce5 100644
--- a/src/platform/windows/win_sockaddr.c
+++ b/src/platform/windows/win_sockaddr.c
@@ -1,6 +1,6 @@
 //
-// Copyright 2017 Garrett D'Amore <garrett@damore.org>
-// Copyright 2017 Capitar IT Group BV <info@capitar.com>
+// Copyright 2018 Staysail Systems, Inc. <info@staysail.tech>
+// Copyright 2018 Capitar IT Group BV <info@capitar.com>
 //
 // This software is supplied under the terms of the MIT License, a
 // copy of which should be located in the distribution where this
@@ -23,21 +23,21 @@ nni_win_nn2sockaddr(SOCKADDR_STORAGE *ss, const nni_sockaddr *sa)
 	if ((ss == NULL) || (sa == NULL)) {
 		return (-1);
 	}
-	switch (sa->s_un.s_family) {
+	switch (sa->s_family) {
 	case NNG_AF_INET:
 		sin = (void *) ss;
 		memset(sin, 0, sizeof(*sin));
 		sin->sin_family      = PF_INET;
-		sin->sin_port        = sa->s_un.s_in.sa_port;
-		sin->sin_addr.s_addr = sa->s_un.s_in.sa_addr;
+		sin->sin_port        = sa->s_in.sa_port;
+		sin->sin_addr.s_addr = sa->s_in.sa_addr;
 		return (sizeof(*sin));
 
 	case NNG_AF_INET6:
 		sin6 = (void *) ss;
 		memset(sin6, 0, sizeof(*sin6));
 		sin6->sin6_family = PF_INET6;
-		sin6->sin6_port   = sa->s_un.s_in6.sa_port;
-		memcpy(sin6->sin6_addr.s6_addr, sa->s_un.s_in6.sa_addr, 16);
+		sin6->sin6_port   = sa->s_in6.sa_port;
+		memcpy(sin6->sin6_addr.s6_addr, sa->s_in6.sa_addr, 16);
 		return (sizeof(*sin6));
 	}
 	return (-1);
@@ -54,17 +54,17 @@ nni_win_sockaddr2nn(nni_sockaddr *sa, const SOCKADDR_STORAGE *ss)
 	}
 	switch (ss->ss_family) {
 	case PF_INET:
-		sin                     = (void *) ss;
-		sa->s_un.s_in.sa_family = NNG_AF_INET;
-		sa->s_un.s_in.sa_port   = sin->sin_port;
-		sa->s_un.s_in.sa_addr   = sin->sin_addr.s_addr;
+		sin                = (void *) ss;
+		sa->s_in.sa_family = NNG_AF_INET;
+		sa->s_in.sa_port   = sin->sin_port;
+		sa->s_in.sa_addr   = sin->sin_addr.s_addr;
 		return (0);
 
 	case PF_INET6:
-		sin6                     = (void *) ss;
-		sa->s_un.s_in6.sa_family = NNG_AF_INET6;
-		sa->s_un.s_in6.sa_port   = sin6->sin6_port;
-		memcpy(sa->s_un.s_in6.sa_addr, sin6->sin6_addr.s6_addr, 16);
+		sin6                = (void *) ss;
+		sa->s_in6.sa_family = NNG_AF_INET6;
+		sa->s_in6.sa_port   = sin6->sin6_port;
+		memcpy(sa->s_in6.sa_addr, sin6->sin6_addr.s6_addr, 16);
 		return (0);
 	}
 	return (-1);
diff --git a/src/platform/windows/win_tcp.c b/src/platform/windows/win_tcp.c
index 8062eb3e..17f7845d 100644
--- a/src/platform/windows/win_tcp.c
+++ b/src/platform/windows/win_tcp.c
@@ -274,10 +274,10 @@ nni_plat_tcp_ep_init(nni_plat_tcp_ep **epp, const nni_sockaddr *lsa,
 
 	ep->s = INVALID_SOCKET;
 
-	if ((rsa != NULL) && (rsa->s_un.s_family != NNG_AF_UNSPEC)) {
+	if ((rsa != NULL) && (rsa->s_family != NNG_AF_UNSPEC)) {
 		ep->remlen = nni_win_nn2sockaddr(&ep->remaddr, rsa);
 	}
-	if ((lsa != NULL) && (lsa->s_un.s_family != NNG_AF_UNSPEC)) {
+	if ((lsa != NULL) && (lsa->s_family != NNG_AF_UNSPEC)) {
 		ep->loclen = nni_win_nn2sockaddr(&ep->locaddr, lsa);
 	}
 
@@ -659,15 +659,15 @@ nni_plat_tcp_ntop(const nni_sockaddr *sa, char *ipstr, char *portstr)
 	const void *ap;
 	uint16_t    port;
 	int         af;
-	switch (sa->s_un.s_family) {
+	switch (sa->s_family) {
 	case NNG_AF_INET:
-		ap   = &sa->s_un.s_in.sa_addr;
-		port = sa->s_un.s_in.sa_port;
+		ap   = &sa->s_in.sa_addr;
+		port = sa->s_in.sa_port;
 		af   = AF_INET;
 		break;
 	case NNG_AF_INET6:
-		ap   = &sa->s_un.s_in6.sa_addr;
-		port = sa->s_un.s_in6.sa_port;
+		ap   = &sa->s_in6.sa_addr;
+		port = sa->s_in6.sa_port;
 		af   = AF_INET6;
 		break;
 	default:
diff --git a/src/transport/inproc/inproc.c b/src/transport/inproc/inproc.c
index f9f438ab..375d8bdd 100644
--- a/src/transport/inproc/inproc.c
+++ b/src/transport/inproc/inproc.c
@@ -183,9 +183,8 @@ nni_inproc_pipe_get_addr(void *arg, void *buf, size_t *szp)
 	nni_sockaddr     sa;
 
 	memset(&sa, 0, sizeof(sa));
-	sa.s_un.s_inproc.sa_family = NNG_AF_INPROC;
-	nni_strlcpy(sa.s_un.s_inproc.sa_path, p->addr,
-	    sizeof(sa.s_un.s_inproc.sa_path));
+	sa.s_inproc.sa_family = NNG_AF_INPROC;
+	nni_strlcpy(sa.s_inproc.sa_name, p->addr, sizeof(sa.s_inproc.sa_name));
 	return (nni_getopt_sockaddr(&sa, buf, szp));
 }
 
diff --git a/src/transport/ipc/ipc.c b/src/transport/ipc/ipc.c
index 41498ca3..fa59f0fe 100644
--- a/src/transport/ipc/ipc.c
+++ b/src/transport/ipc/ipc.c
@@ -120,11 +120,11 @@ nni_ipc_pipe_init(nni_ipc_pipe **pipep, nni_ipc_ep *ep, void *ipp)
 		return (rv);
 	}
 
-	p->proto                    = ep->proto;
-	p->rcvmax                   = ep->rcvmax;
-	p->ipp                      = ipp;
-	p->sa.s_un.s_path.sa_family = NNG_AF_IPC;
-	p->sa                       = ep->sa;
+	p->proto              = ep->proto;
+	p->rcvmax             = ep->rcvmax;
+	p->ipp                = ipp;
+	p->sa.s_ipc.sa_family = NNG_AF_IPC;
+	p->sa                 = ep->sa;
 
 	*pipep = p;
 	return (0);
@@ -524,10 +524,10 @@ nni_ipc_ep_init(void **epp, nni_url *url, nni_sock *sock, int mode)
 	}
 	nni_mtx_init(&ep->mtx);
 
-	sz                           = sizeof(ep->sa.s_un.s_path.sa_path);
-	ep->sa.s_un.s_path.sa_family = NNG_AF_IPC;
+	sz                     = sizeof(ep->sa.s_ipc.sa_path);
+	ep->sa.s_ipc.sa_family = NNG_AF_IPC;
 
-	if (nni_strlcpy(ep->sa.s_un.s_path.sa_path, url->u_path, sz) >= sz) {
+	if (nni_strlcpy(ep->sa.s_ipc.sa_path, url->u_path, sz) >= sz) {
 		nni_ipc_ep_fini(ep);
 		return (NNG_EADDRINVAL);
 	}
diff --git a/src/transport/tcp/tcp.c b/src/transport/tcp/tcp.c
index 2a23b88b..1b4e6dc2 100644
--- a/src/transport/tcp/tcp.c
+++ b/src/transport/tcp/tcp.c
@@ -555,16 +555,16 @@ nni_tcp_ep_init(void **epp, nni_url *url, nni_sock *sock, int mode)
 	// XXX: arguably we could defer this part to the point we do a bind
 	// or connect!
 	if (mode == NNI_EP_MODE_DIAL) {
-		passive           = 0;
-		lsa.s_un.s_family = NNG_AF_UNSPEC;
+		passive      = 0;
+		lsa.s_family = NNG_AF_UNSPEC;
 		nni_aio_set_input(aio, 0, &rsa);
 		if ((host == NULL) || (serv == NULL)) {
 			nni_aio_fini(aio);
 			return (NNG_EADDRINVAL);
 		}
 	} else {
-		passive           = 1;
-		rsa.s_un.s_family = NNG_AF_UNSPEC;
+		passive      = 1;
+		rsa.s_family = NNG_AF_UNSPEC;
 		nni_aio_set_input(aio, 0, &lsa);
 	}
 
diff --git a/src/transport/tls/tls.c b/src/transport/tls/tls.c
index cf849373..534b955d 100644
--- a/src/transport/tls/tls.c
+++ b/src/transport/tls/tls.c
@@ -568,20 +568,20 @@ nni_tls_ep_init(void **epp, nni_url *url, nni_sock *sock, int mode)
 	}
 
 	if (mode == NNI_EP_MODE_DIAL) {
-		passive           = 0;
-		tlsmode           = NNG_TLS_MODE_CLIENT;
-		authmode          = NNG_TLS_AUTH_MODE_REQUIRED;
-		lsa.s_un.s_family = NNG_AF_UNSPEC;
+		passive      = 0;
+		tlsmode      = NNG_TLS_MODE_CLIENT;
+		authmode     = NNG_TLS_AUTH_MODE_REQUIRED;
+		lsa.s_family = NNG_AF_UNSPEC;
 		nni_aio_set_input(aio, 0, &rsa);
 		if ((host == NULL) || (serv == NULL)) {
 			nni_aio_fini(aio);
 			return (NNG_EADDRINVAL);
 		}
 	} else {
-		passive           = 1;
-		tlsmode           = NNG_TLS_MODE_SERVER;
-		authmode          = NNG_TLS_AUTH_MODE_NONE;
-		rsa.s_un.s_family = NNG_AF_UNSPEC;
+		passive      = 1;
+		tlsmode      = NNG_TLS_MODE_SERVER;
+		authmode     = NNG_TLS_AUTH_MODE_NONE;
+		rsa.s_family = NNG_AF_UNSPEC;
 		nni_aio_set_input(aio, 0, &lsa);
 	}
 
diff --git a/src/transport/zerotier/zerotier.c b/src/transport/zerotier/zerotier.c
index 01c290db..2a427ca0 100644
--- a/src/transport/zerotier/zerotier.c
+++ b/src/transport/zerotier/zerotier.c
@@ -345,7 +345,7 @@ zt_node_rcv4_cb(void *arg)
 
 	memset(&sa, 0, sizeof(sa));
 	sin                  = (void *) &sa;
-	nsin                 = &ztn->zn_rcv4_addr.s_un.s_in;
+	nsin                 = &ztn->zn_rcv4_addr.s_in;
 	sin->sin_family      = AF_INET;
 	sin->sin_port        = nsin->sa_port;
 	sin->sin_addr.s_addr = nsin->sa_addr;
@@ -397,7 +397,7 @@ zt_node_rcv6_cb(void *arg)
 
 	memset(&sa, 0, sizeof(sa));
 	sin6              = (void *) &sa;
-	nsin6             = &ztn->zn_rcv6_addr.s_un.s_in6;
+	nsin6             = &ztn->zn_rcv6_addr.s_in6;
 	sin6->sin6_family = AF_INET6;
 	sin6->sin6_port   = nsin6->sa_port;
 	memcpy(&sin6->sin6_addr, nsin6->sa_addr, 16);
@@ -1326,18 +1326,18 @@ zt_wire_packet_send(ZT_Node *node, void *userptr, void *thr, int64_t socket,
 	// the platform layer.
 	switch (sin->sin_family) {
 	case AF_INET:
-		addr.s_un.s_in.sa_family = NNG_AF_INET;
-		addr.s_un.s_in.sa_port   = sin->sin_port;
-		addr.s_un.s_in.sa_addr   = sin->sin_addr.s_addr;
-		udp                      = ztn->zn_udp4;
-		port                     = htons(sin->sin_port);
+		addr.s_in.sa_family = NNG_AF_INET;
+		addr.s_in.sa_port   = sin->sin_port;
+		addr.s_in.sa_addr   = sin->sin_addr.s_addr;
+		udp                 = ztn->zn_udp4;
+		port                = htons(sin->sin_port);
 		break;
 	case AF_INET6:
-		addr.s_un.s_in6.sa_family = NNG_AF_INET6;
-		addr.s_un.s_in6.sa_port   = sin6->sin6_port;
-		udp                       = ztn->zn_udp6;
-		port                      = htons(sin6->sin6_port);
-		memcpy(addr.s_un.s_in6.sa_addr, sin6->sin6_addr.s6_addr, 16);
+		addr.s_in6.sa_family = NNG_AF_INET6;
+		addr.s_in6.sa_port   = sin6->sin6_port;
+		udp                  = ztn->zn_udp6;
+		port                 = htons(sin6->sin6_port);
+		memcpy(addr.s_in6.sa_addr, sin6->sin6_addr.s6_addr, 16);
 		break;
 	default:
 		// No way to understand the address.
@@ -1440,9 +1440,9 @@ zt_node_create(zt_node **ztnp, const char *path)
 
 	// We want to bind to any address we can (for now).
 	memset(&sa4, 0, sizeof(sa4));
-	sa4.s_un.s_in.sa_family = NNG_AF_INET;
+	sa4.s_in.sa_family = NNG_AF_INET;
 	memset(&sa6, 0, sizeof(sa6));
-	sa6.s_un.s_in6.sa_family = NNG_AF_INET6;
+	sa6.s_in6.sa_family = NNG_AF_INET6;
 
 	if ((ztn = NNI_ALLOC_STRUCT(ztn)) == NULL) {
 		return (NNG_ENOMEM);
@@ -2747,10 +2747,10 @@ zt_pipe_getopt_locaddr(void *arg, void *data, size_t *szp)
 	nng_sockaddr sa;
 
 	memset(&sa, 0, sizeof(sa));
-	sa.s_un.s_zt.sa_family = NNG_AF_ZT;
-	sa.s_un.s_zt.sa_nwid   = p->zp_nwid;
-	sa.s_un.s_zt.sa_nodeid = p->zp_laddr >> zt_port_shift;
-	sa.s_un.s_zt.sa_port   = p->zp_laddr & zt_port_mask;
+	sa.s_zt.sa_family = NNG_AF_ZT;
+	sa.s_zt.sa_nwid   = p->zp_nwid;
+	sa.s_zt.sa_nodeid = p->zp_laddr >> zt_port_shift;
+	sa.s_zt.sa_port   = p->zp_laddr & zt_port_mask;
 	return (nni_getopt_sockaddr(&sa, data, szp));
 }
 
@@ -2761,10 +2761,10 @@ zt_pipe_getopt_remaddr(void *arg, void *data, size_t *szp)
 	nng_sockaddr sa;
 
 	memset(&sa, 0, sizeof(sa));
-	sa.s_un.s_zt.sa_family = NNG_AF_ZT;
-	sa.s_un.s_zt.sa_nwid   = p->zp_nwid;
-	sa.s_un.s_zt.sa_nodeid = p->zp_raddr >> zt_port_shift;
-	sa.s_un.s_zt.sa_port   = p->zp_raddr & zt_port_mask;
+	sa.s_zt.sa_family = NNG_AF_ZT;
+	sa.s_zt.sa_nwid   = p->zp_nwid;
+	sa.s_zt.sa_nodeid = p->zp_raddr >> zt_port_shift;
+	sa.s_zt.sa_port   = p->zp_raddr & zt_port_mask;
 	return (nni_getopt_sockaddr(&sa, data, szp));
 }