Add endpoint tuning of maxrcv size. Fix cmsg API.

The CMSG handling was completely borked.  This is fixed now, and
we stash the SP header size (ugh) in the CMSG contents to match what
nanomsg does.  We now pass the cmsg validation test.

We also fixed handling of certain endpoint-related options, so that
endpoints can get options from the socket at initialization time.
This required a minor change to the transport API for endpoints.

Finally, we fixed a critical fault in the REP handling of RAW sockets,
which caused them to always return NNG_ESTATE in all cases.  It should
now honor the actual socket option.

2 files changed, 115 insertions, 0 deletions

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 52c9fdba..57230f33 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -86,4 +86,5 @@ add_nng_test(survey 5)
 add_nng_test(tcp 5)
 
 # compatbility tests
+add_nng_compat_test(compat_cmsg 5)
 add_nng_compat_test(compat_reqrep 5)
diff --git a/tests/compat_cmsg.c b/tests/compat_cmsg.c
new file mode 100644
index 00000000..4d70dabe
--- /dev/null
+++ b/tests/compat_cmsg.c
@@ -0,0 +1,114 @@
+/*
+    Copyright (c) 2014 Martin Sustrik  All rights reserved.
+    Copyright 2015 Garrett D'Amore <garrett@damore.org>
+    Copyright 2016 Franklin "Snaipe" Mathieu <franklinmathieu@gmail.com>
+
+    Permission is hereby granted, free of charge, to any person obtaining a copy
+    of this software and associated documentation files (the "Software"),
+    to deal in the Software without restriction, including without limitation
+    the rights to use, copy, modify, merge, publish, distribute, sublicense,
+    and/or sell copies of the Software, and to permit persons to whom
+    the Software is furnished to do so, subject to the following conditions:
+
+    The above copyright notice and this permission notice shall be included
+    in all copies or substantial portions of the Software.
+
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+    THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+    FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+    IN THE SOFTWARE.
+*/
+
+#include "nng_compat.h"
+#include "compat_testutil.h"
+
+int main (int argc, const char *argv[])
+{
+    int rc;
+    int rep;
+    int req;
+    struct nn_msghdr hdr;
+    struct nn_iovec iovec;
+    unsigned char body [3];
+    unsigned char ctrl [256];
+    struct nn_cmsghdr *cmsg;
+    unsigned char *data;
+    void *buf;
+    char socket_address[128];
+
+    test_addr_from(socket_address, "tcp", "127.0.0.1",
+            get_test_port(argc, argv));
+    strcpy(socket_address, "inproc://testaddr");
+    
+    rep = test_socket (AF_SP_RAW, NN_REP);
+    test_bind (rep, socket_address);
+    req = test_socket (AF_SP, NN_REQ);
+    test_connect (req, socket_address);
+
+    /* Test ancillary data in static buffer. */
+
+    test_send (req, "ABC");
+
+    iovec.iov_base = body;
+    iovec.iov_len = sizeof (body);
+    hdr.msg_iov = &iovec;
+    hdr.msg_iovlen = 1;
+    hdr.msg_control = ctrl;
+    hdr.msg_controllen = sizeof (ctrl);
+    rc = nn_recvmsg (rep, &hdr, 0);
+    errno_assert (rc == 3);
+
+    cmsg = NN_CMSG_FIRSTHDR (&hdr);
+    while (1) {
+        nn_assert (cmsg);
+        if (cmsg->cmsg_level == PROTO_SP && cmsg->cmsg_type == SP_HDR)
+            break;
+        cmsg = NN_CMSG_NXTHDR (&hdr, cmsg);
+    }
+    nn_assert (cmsg->cmsg_len == NN_CMSG_SPACE (8+sizeof (size_t)));
+    data = NN_CMSG_DATA (cmsg);
+    nn_assert (!(data[0+sizeof (size_t)] & 0x80));
+    nn_assert (data[4+sizeof (size_t)] & 0x80);
+
+    rc = nn_sendmsg (rep, &hdr, 0);
+    nn_assert (rc == 3);
+    test_recv (req, "ABC");
+
+    /* Test ancillary data in dynamically allocated buffer (NN_MSG). */
+
+    test_send (req, "ABC");
+
+    iovec.iov_base = body;
+    iovec.iov_len = sizeof (body);
+    hdr.msg_iov = &iovec;
+    hdr.msg_iovlen = 1;
+    hdr.msg_control = &buf;
+    hdr.msg_controllen = NN_MSG;
+    rc = nn_recvmsg (rep, &hdr, 0);
+    errno_assert (rc == 3);
+
+    cmsg = NN_CMSG_FIRSTHDR (&hdr);
+    while (1) {
+        nn_assert (cmsg);
+        if (cmsg->cmsg_level == PROTO_SP && cmsg->cmsg_type == SP_HDR)
+            break;
+        cmsg = NN_CMSG_NXTHDR (&hdr, cmsg);
+    }
+    nn_assert (cmsg->cmsg_len == NN_CMSG_SPACE (8+sizeof (size_t)));
+    data = NN_CMSG_DATA (cmsg);
+    nn_assert (!(data[0+sizeof (size_t)] & 0x80));
+    nn_assert (data[4+sizeof (size_t)] & 0x80);
+
+    rc = nn_sendmsg (rep, &hdr, 0);
+    nn_assert (rc == 3);
+    test_recv (req, "ABC");
+
+    test_close (req);
+    test_close (rep);
+
+    return 0;
+}
+