From 77311bfcc94bba96cdee73ddcd1ac9a6d0ed17d2 Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Tue, 14 Aug 2018 15:57:57 +0500 Subject: fixes #208 pipe start should occur before connect / accept fixes #599 nng_dial sync should not return until added to socket This reintroduces the changes for the above fixes, building upon the transport modifications that we have made to eliminate the separate transport pipe start entry point. It also includes slightly reworked code during start to put a hold on the pipe when it is created, which we we drop at the end, hopefully fixing a use-after-free. --- src/core/pipe.h | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/core/pipe.h') diff --git a/src/core/pipe.h b/src/core/pipe.h index 1d73ce51..1e2f2b5d 100644 --- a/src/core/pipe.h +++ b/src/core/pipe.h @@ -59,11 +59,6 @@ extern uint32_t nni_pipe_listener_id(nni_pipe *); // nni_pipe_dialer_id returns the dialer id for the pipe (or 0 if none). extern uint32_t nni_pipe_dialer_id(nni_pipe *); -// nni_pipe_closed returns true if nni_pipe_close was called. -// (This is used by the socket to determine if user closed the pipe -// during callback.) -extern bool nni_pipe_closed(nni_pipe *); - // nni_pipe_rele releases the hold on the pipe placed by nni_pipe_find. extern void nni_pipe_rele(nni_pipe *); -- cgit v1.2.3-70-g09d2