From c2aa8c12e705ba77f3d2d28c5ba0a9ec7efb7632 Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Sat, 25 Oct 2025 20:28:43 -0700 Subject: Drop the protocol version for internal implementations. The ops vector / protocol API/ABI were meant to support external implementations, but we have moved away from having pluggable protocols, and we aren't likely to support it any time soon. --- src/core/protocol.h | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'src/core/protocol.h') diff --git a/src/core/protocol.h b/src/core/protocol.h index c128e676..8f7e9e39 100644 --- a/src/core/protocol.h +++ b/src/core/protocol.h @@ -124,7 +124,6 @@ typedef struct nni_proto_id { } nni_proto_id; struct nni_proto { - uint32_t proto_version; // Ops vector version nni_proto_id proto_self; // Our identity nni_proto_id proto_peer; // Peer identity uint32_t proto_flags; // Protocol flags @@ -133,17 +132,6 @@ struct nni_proto { const nni_proto_ctx_ops *proto_ctx_ops; // Context operations }; -// We quite intentionally use a signature where the upper word is nonzero, -// which ensures that if we get garbage we will reject it. This is more -// likely to mismatch than all zero bytes would. The actual version is -// stored in the lower word; this is not semver -- the numbers are just -// increasing - we doubt it will increase more than a handful of times -// during the life of the project. If we add a new version, please keep -// the old version around -- it may be possible to automatically convert -// older versions in the future. -#define NNI_PROTOCOL_V3 0x50520003u // "pr\0\3" -#define NNI_PROTOCOL_VERSION NNI_PROTOCOL_V3 - // These flags determine which operations make sense. We use them so that // we can reject attempts to create notification fds for operations that make // no sense. Also, we can detect raw mode, thereby providing handling for -- cgit v1.2.3-70-g09d2