From fe3c9705072ac8cafecdf2ea6bca4c26f9464824 Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Wed, 28 Jun 2017 23:07:28 -0700 Subject: Refactor stop again, closing numerous races (thanks valgrind!) --- src/core/taskq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/core/taskq.c') diff --git a/src/core/taskq.c b/src/core/taskq.c index f33a68bf..f4a0beee 100644 --- a/src/core/taskq.c +++ b/src/core/taskq.c @@ -184,7 +184,9 @@ nni_taskq_cancel(nni_taskq *tq, nni_taskq_ent *ent) nni_mtx_unlock(&tq->tq_mtx); return (NNG_ENOENT); } - nni_list_remove(&tq->tq_ents, ent); + if (nni_list_active(&tq->tq_ents, ent)) { + nni_list_remove(&tq->tq_ents, ent); + } nni_mtx_unlock(&tq->tq_mtx); return (0); } -- cgit v1.2.3-70-g09d2