From 3ca7bcc0edd0f26c33264d32e7b6f07276e72e3c Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Sat, 7 Dec 2024 19:32:40 -0800 Subject: aio: task_abort was a mistake The use of task_abort to prematurely fail an aio at scheduling time was a mistake, because it could have led to duplicate calls to nng_aio_finish(). We do need to ensure that we leave an indicator so that nni_aio_schedule can return the abort status to caller, in the case that abort is called between the nni_aio_begin and nni_aio_schedule calls. --- src/core/taskq.h | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/core/taskq.h') diff --git a/src/core/taskq.h b/src/core/taskq.h index d3299433..356ef725 100644 --- a/src/core/taskq.h +++ b/src/core/taskq.h @@ -40,11 +40,6 @@ extern void nni_task_exec(nni_task *); // nni_task_exec). extern void nni_task_prep(nni_task *); -// nni_task_abort is called to undo the effect of nni_task_prep, -// basically. The aio framework uses this when nni_aio_schedule() -// returns an error. -extern void nni_task_abort(nni_task *); - // nni_task_busy checks to see if a task is still busy. // This is uses the same check that nni_task_wait uses. extern bool nni_task_busy(nni_task *); -- cgit v1.2.3-70-g09d2