From cb5febaea9d877209cc84fce7fd758f958613115 Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Sat, 23 Nov 2024 07:45:41 -0800 Subject: dialer/listener: don't allocate before we have a transport This permits removal of an extra bit of clean up. --- src/core/dialer.c | 7 +++---- src/core/listener.c | 7 +++---- 2 files changed, 6 insertions(+), 8 deletions(-) (limited to 'src/core') diff --git a/src/core/dialer.c b/src/core/dialer.c index 3cd6620f..5e44cbff 100644 --- a/src/core/dialer.c +++ b/src/core/dialer.c @@ -216,14 +216,13 @@ nni_dialer_create(nni_dialer **dp, nni_sock *s, const char *url_str) nni_dialer *d; int rv; - if ((d = NNI_ALLOC_STRUCT(d)) == NULL) { - return (NNG_ENOMEM); - } if (((tran = nni_sp_tran_find(url_str)) == NULL) || (tran->tran_dialer == NULL)) { - NNI_FREE_STRUCT(d); return (NNG_ENOTSUP); } + if ((d = NNI_ALLOC_STRUCT(d)) == NULL) { + return (NNG_ENOMEM); + } if ((rv = nni_url_parse_inline(&d->d_url, url_str)) != 0) { nni_url_fini(&d->d_url); NNI_FREE_STRUCT(d); diff --git a/src/core/listener.c b/src/core/listener.c index 3c2d7bf0..10096559 100644 --- a/src/core/listener.c +++ b/src/core/listener.c @@ -204,14 +204,13 @@ nni_listener_create(nni_listener **lp, nni_sock *s, const char *url_str) nni_listener *l; int rv; - if ((l = NNI_ALLOC_STRUCT(l)) == NULL) { - return (NNG_ENOMEM); - } if (((tran = nni_sp_tran_find(url_str)) == NULL) || (tran->tran_listener == NULL)) { - NNI_FREE_STRUCT(l); return (NNG_ENOTSUP); } + if ((l = NNI_ALLOC_STRUCT(l)) == NULL) { + return (NNG_ENOMEM); + } if ((rv = nni_url_parse_inline(&l->l_url, url_str)) != 0) { nni_url_fini(&l->l_url); NNI_FREE_STRUCT(l); -- cgit v1.2.3-70-g09d2