From 53e8dbbe3c2bd82fb7ac8583a45e7fcfec173cc1 Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Sun, 20 Oct 2024 23:43:44 -0700 Subject: remove legacy support for configuration of transport options on socket Transport specific options should be configured on the end point. This has the most impact for TLS, as TLS dialers and listeners will need to be allocated apriori, to configure TLS options. Some legacy tests were removed... we're going to remove the legacy libnanomsg compatibility layer anyway. --- src/platform/posix/posix_tcpdial.c | 3 ++- src/platform/posix/posix_tcplisten.c | 3 ++- src/platform/windows/win_tcpdial.c | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) (limited to 'src/platform') diff --git a/src/platform/posix/posix_tcpdial.c b/src/platform/posix/posix_tcpdial.c index cf3d9368..6aea8ae5 100644 --- a/src/platform/posix/posix_tcpdial.c +++ b/src/platform/posix/posix_tcpdial.c @@ -37,7 +37,8 @@ nni_tcp_dialer_init(nni_tcp_dialer **dp) return (NNG_ENOMEM); } nni_mtx_init(&d->mtx); - d->closed = false; + d->closed = false; + d->nodelay = true; nni_aio_list_init(&d->connq); nni_atomic_init_bool(&d->fini); nni_atomic_init64(&d->ref); diff --git a/src/platform/posix/posix_tcplisten.c b/src/platform/posix/posix_tcplisten.c index 95be4beb..a38411c5 100644 --- a/src/platform/posix/posix_tcplisten.c +++ b/src/platform/posix/posix_tcplisten.c @@ -1,5 +1,5 @@ // -// Copyright 2020 Staysail Systems, Inc. +// Copyright 2024 Staysail Systems, Inc. // Copyright 2018 Capitar IT Group BV // Copyright 2018 Devolutions // @@ -56,6 +56,7 @@ nni_tcp_listener_init(nni_tcp_listener **lp) l->pfd = NULL; l->closed = false; l->started = false; + l->nodelay = true; nni_aio_list_init(&l->acceptq); *lp = l; diff --git a/src/platform/windows/win_tcpdial.c b/src/platform/windows/win_tcpdial.c index bc5d6f5d..dbdd0762 100644 --- a/src/platform/windows/win_tcpdial.c +++ b/src/platform/windows/win_tcpdial.c @@ -43,6 +43,7 @@ nni_tcp_dialer_init(nni_tcp_dialer **dp) ZeroMemory(d, sizeof(*d)); nni_mtx_init(&d->mtx); nni_aio_list_init(&d->aios); + d->nodelay = true; // Create a scratch socket for use with ioctl. s = socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP); -- cgit v1.2.3-70-g09d2