From abab1392c11395d387e3072c4f5788d284846093 Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Wed, 26 Feb 2020 00:22:11 -0800 Subject: fixes #1171 message header could be inlined in the message structure This uses a maximum 64-byte header and should avoid allocations and cache misses, leading to a small performance boost overall. --- src/protocol/survey0/survey.c | 4 ++-- src/protocol/survey0/xrespond.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/protocol/survey0') diff --git a/src/protocol/survey0/survey.c b/src/protocol/survey0/survey.c index 22677a17..e4cdca2c 100644 --- a/src/protocol/survey0/survey.c +++ b/src/protocol/survey0/survey.c @@ -244,7 +244,7 @@ surv0_ctx_send(void *arg, nni_aio *aio) return; } nni_msg_header_clear(msg); - nni_msg_header_must_append_u32(msg, (uint32_t) ctx->survey_id); + nni_msg_header_append_u32(msg, (uint32_t) ctx->survey_id); // From this point, we're committed to success. Note that we send // regardless of whether there are any pipes or not. If no pipes, @@ -473,7 +473,7 @@ surv0_pipe_recv_cb(void *arg) return; } id = nni_msg_trim_u32(msg); - nni_msg_header_must_append_u32(msg, id); + nni_msg_header_append_u32(msg, id); nni_mtx_lock(&sock->mtx); // Best effort at delivery. Discard if no context or context is diff --git a/src/protocol/survey0/xrespond.c b/src/protocol/survey0/xrespond.c index c664f009..25aacc2c 100644 --- a/src/protocol/survey0/xrespond.c +++ b/src/protocol/survey0/xrespond.c @@ -284,7 +284,7 @@ xresp0_recv_cb(void *arg) nni_msg_set_pipe(msg, p->id); // Store the pipe id in the header, first thing. - nni_msg_header_must_append_u32(msg, p->id); + nni_msg_header_append_u32(msg, p->id); // Move backtrace from body to header hops = 1; -- cgit v1.2.3-70-g09d2