From 45bc175ef9278c175d2fc3a0678b49b18e74c449 Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Wed, 14 Feb 2018 14:50:04 -0800 Subject: fixes #234 Investigate enabling more verbose compiler warnings We enabled verbose compiler warnings, and found a lot of issues. Some of these were even real bugs. As a bonus, we actually save some initialization steps in the compat layer, and avoid passing some variables we don't need. --- src/protocol/pipeline0/pull.c | 1 + src/protocol/pipeline0/push.c | 1 + src/protocol/pubsub0/pub.c | 1 + src/protocol/pubsub0/sub.c | 1 + src/protocol/survey0/survey.c | 5 +++++ 5 files changed, 9 insertions(+) (limited to 'src/protocol') diff --git a/src/protocol/pipeline0/pull.c b/src/protocol/pipeline0/pull.c index 44eb87f9..76c680c1 100644 --- a/src/protocol/pipeline0/pull.c +++ b/src/protocol/pipeline0/pull.c @@ -196,6 +196,7 @@ pull0_sock_getopt_raw(void *arg, void *buf, size_t *szp) static void pull0_sock_send(void *arg, nni_aio *aio) { + NNI_ARG_UNUSED(arg); nni_aio_finish_error(aio, NNG_ENOTSUP); } diff --git a/src/protocol/pipeline0/push.c b/src/protocol/pipeline0/push.c index 2829e2aa..1e6cf30e 100644 --- a/src/protocol/pipeline0/push.c +++ b/src/protocol/pipeline0/push.c @@ -221,6 +221,7 @@ push0_sock_send(void *arg, nni_aio *aio) static void push0_sock_recv(void *arg, nni_aio *aio) { + NNI_ARG_UNUSED(arg); nni_aio_finish_error(aio, NNG_ENOTSUP); } diff --git a/src/protocol/pubsub0/pub.c b/src/protocol/pubsub0/pub.c index 285f40ca..33ecb5ba 100644 --- a/src/protocol/pubsub0/pub.c +++ b/src/protocol/pubsub0/pub.c @@ -290,6 +290,7 @@ pub0_sock_getopt_raw(void *arg, void *buf, size_t *szp) static void pub0_sock_recv(void *arg, nni_aio *aio) { + NNI_ARG_UNUSED(arg); nni_aio_finish_error(aio, NNG_ENOTSUP); } diff --git a/src/protocol/pubsub0/sub.c b/src/protocol/pubsub0/sub.c index a756e326..8803ab19 100644 --- a/src/protocol/pubsub0/sub.c +++ b/src/protocol/pubsub0/sub.c @@ -292,6 +292,7 @@ sub0_sock_getopt_raw(void *arg, void *buf, size_t *szp) static void sub0_sock_send(void *arg, nni_aio *aio) { + NNI_ARG_UNUSED(arg); nni_aio_finish_error(aio, NNG_ENOTSUP); } diff --git a/src/protocol/survey0/survey.c b/src/protocol/survey0/survey.c index b8f10f0e..637ce2e2 100644 --- a/src/protocol/survey0/survey.c +++ b/src/protocol/survey0/survey.c @@ -474,6 +474,11 @@ static nni_proto_sock_option surv0_sock_options[] = { .pso_getopt = surv0_sock_getopt_surveytime, .pso_setopt = surv0_sock_setopt_surveytime, }, + { + .pso_name = NNG_OPT_MAXTTL, + .pso_getopt = surv0_sock_getopt_maxttl, + .pso_setopt = surv0_sock_setopt_maxttl, + }, // terminate list { NULL, NULL, NULL }, }; -- cgit v1.2.3-70-g09d2