From 45bc175ef9278c175d2fc3a0678b49b18e74c449 Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Wed, 14 Feb 2018 14:50:04 -0800 Subject: fixes #234 Investigate enabling more verbose compiler warnings We enabled verbose compiler warnings, and found a lot of issues. Some of these were even real bugs. As a bonus, we actually save some initialization steps in the compat layer, and avoid passing some variables we don't need. --- src/supplemental/websocket/websocket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/supplemental/websocket') diff --git a/src/supplemental/websocket/websocket.c b/src/supplemental/websocket/websocket.c index 05a2c62c..cf3fa8dc 100644 --- a/src/supplemental/websocket/websocket.c +++ b/src/supplemental/websocket/websocket.c @@ -660,7 +660,7 @@ ws_send_control(nni_ws *ws, uint8_t op, uint8_t *buf, size_t len) nni_mtx_lock(&ws->mtx); if ((ws->closed) || - (ws_msg_init_control(&wm, ws, op, buf, sizeof(buf)) != 0)) { + (ws_msg_init_control(&wm, ws, op, buf, len) != 0)) { nni_mtx_unlock(&ws->mtx); return; } @@ -1768,7 +1768,7 @@ ws_conn_cb(void *arg) } for (int i = 0; i < 16; i++) { - raw[i] = nni_random(); + raw[i] = (uint8_t) nni_random(); } nni_base64_encode(raw, 16, wskey, 24); wskey[24] = '\0'; -- cgit v1.2.3-70-g09d2