From 1d033484ee1a2ec26d3eead073e7bc0f889ffdf4 Mon Sep 17 00:00:00 2001 From: Garrett D'Amore Date: Tue, 15 May 2018 01:47:12 -0700 Subject: fixes #419 want to nni_aio_stop without blocking (#428) * fixes #419 want to nni_aio_stop without blocking This actually introduces an nni_aio_close() API that causes nni_aio_begin to return NNG_ECLOSED, while scheduling a callback on the AIO to do an NNG_ECLOSED as well. This should be called in non-blocking close() contexts instead of nni_aio_stop(), and the cases where we call nni_aio_fini() multiple times are updated updated to add nni_aio_stop() calls on all "interlinked" aios before finalizing them. Furthermore, we call nni_aio_close() as soon as practical in the close path. This closes an annoying race condition where the callback from a lower subsystem could wind up rescheduling an operation that we wanted to abort. --- src/transport/inproc/inproc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/transport/inproc') diff --git a/src/transport/inproc/inproc.c b/src/transport/inproc/inproc.c index 0f159d3a..bc51d971 100644 --- a/src/transport/inproc/inproc.c +++ b/src/transport/inproc/inproc.c @@ -198,7 +198,7 @@ nni_inproc_ep_init(void **epp, nni_url *url, nni_sock *sock, int mode) } ep->mode = mode; - ep->proto = nni_sock_proto(sock); + ep->proto = nni_sock_proto_id(sock); NNI_LIST_INIT(&ep->clients, nni_inproc_ep, node); nni_aio_list_init(&ep->aios); @@ -452,7 +452,7 @@ static nni_tran_pipe_option nni_inproc_pipe_options[] = { }, }; -static nni_tran_pipe nni_inproc_pipe_ops = { +static nni_tran_pipe_ops nni_inproc_pipe_ops = { .p_fini = nni_inproc_pipe_fini, .p_send = nni_inproc_pipe_send, .p_recv = nni_inproc_pipe_recv, @@ -468,7 +468,7 @@ static nni_tran_ep_option nni_inproc_ep_options[] = { }, }; -static nni_tran_ep nni_inproc_ep_ops = { +static nni_tran_ep_ops nni_inproc_ep_ops = { .ep_init = nni_inproc_ep_init, .ep_fini = nni_inproc_ep_fini, .ep_connect = nni_inproc_ep_connect, -- cgit v1.2.3-70-g09d2