From 06ae767b12b8e26fecce6c882fec25911a98776c Mon Sep 17 00:00:00 2001 From: Kristóf Havasi Date: Sun, 11 Apr 2021 00:01:23 +0200 Subject: fixes #1436 Guard against UB in sub0_ctx_subscribe (#1437) In case sub0_ctx_subscribe is called to subscribe to _all_ topics --- src/sp/protocol/pubsub0/sub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/sp/protocol/pubsub0/sub.c b/src/sp/protocol/pubsub0/sub.c index 9f3f2283..a40ee073 100644 --- a/src/sp/protocol/pubsub0/sub.c +++ b/src/sp/protocol/pubsub0/sub.c @@ -493,7 +493,9 @@ sub0_ctx_subscribe(void *arg, const void *buf, size_t sz, nni_type t) NNI_FREE_STRUCT(new_topic); return (NNG_ENOMEM); } - memcpy(new_topic->buf, buf, sz); + if (buf && new_topic->buf) { + memcpy(new_topic->buf, buf, sz); + } new_topic->len = sz; nni_list_append(&ctx->topics, new_topic); nni_mtx_unlock(&sock->lk); -- cgit v1.2.3-70-g09d2