From 70f84c85cd5fd194519300e3c88b4164d2e2d29c Mon Sep 17 00:00:00 2001 From: Jesper Wramberg Date: Thu, 22 Jul 2021 08:10:35 +0200 Subject: Fix valgrind error epoll_ctl points to uninitialised bytes (#1469) While not strictly an error, valgrind reports it as an error. This commit zero initializes the epoll_event before parsing it to the system call. --- src/platform/posix/posix_pollq_epoll.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src') diff --git a/src/platform/posix/posix_pollq_epoll.c b/src/platform/posix/posix_pollq_epoll.c index fc55f76f..dde331d5 100644 --- a/src/platform/posix/posix_pollq_epoll.c +++ b/src/platform/posix/posix_pollq_epoll.c @@ -107,6 +107,7 @@ nni_posix_pfd_init(nni_posix_pfd **pfdp, int fd) NNI_LIST_NODE_INIT(&pfd->node); // notifications disabled to begin with + memset(&ev, 0, sizeof(ev)); ev.events = 0; ev.data.ptr = pfd; @@ -138,6 +139,7 @@ nni_posix_pfd_arm(nni_posix_pfd *pfd, unsigned events) pfd->events |= events; events = pfd->events; + memset(&ev, 0, sizeof(ev)); ev.events = events | NNI_EPOLL_FLAGS; ev.data.ptr = pfd; -- cgit v1.2.3-70-g09d2