aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJesper Wramberg <Wramberg@users.noreply.github.com>2021-07-22 08:10:35 +0200
committerGitHub <noreply@github.com>2021-07-21 23:10:35 -0700
commit70f84c85cd5fd194519300e3c88b4164d2e2d29c (patch)
treebe01175a7e3b756dbbabf1d93bff6ef16fd17c9d
parent62caed11b0abab77de221e1a745a262436d1ecbf (diff)
downloadnng-70f84c85cd5fd194519300e3c88b4164d2e2d29c.tar.gz
nng-70f84c85cd5fd194519300e3c88b4164d2e2d29c.tar.bz2
nng-70f84c85cd5fd194519300e3c88b4164d2e2d29c.zip
Fix valgrind error epoll_ctl points to uninitialised bytes (#1469)
While not strictly an error, valgrind reports it as an error. This commit zero initializes the epoll_event before parsing it to the system call.
-rw-r--r--src/platform/posix/posix_pollq_epoll.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/platform/posix/posix_pollq_epoll.c b/src/platform/posix/posix_pollq_epoll.c
index fc55f76f..dde331d5 100644
--- a/src/platform/posix/posix_pollq_epoll.c
+++ b/src/platform/posix/posix_pollq_epoll.c
@@ -107,6 +107,7 @@ nni_posix_pfd_init(nni_posix_pfd **pfdp, int fd)
NNI_LIST_NODE_INIT(&pfd->node);
// notifications disabled to begin with
+ memset(&ev, 0, sizeof(ev));
ev.events = 0;
ev.data.ptr = pfd;
@@ -138,6 +139,7 @@ nni_posix_pfd_arm(nni_posix_pfd *pfd, unsigned events)
pfd->events |= events;
events = pfd->events;
+ memset(&ev, 0, sizeof(ev));
ev.events = events | NNI_EPOLL_FLAGS;
ev.data.ptr = pfd;