Work for test refactoring.

There are a few major areas in this change.

* CMake options are now located in a common cmake/NNGOptions.cmake
  file.  This should make it easier for folks to figure out what
  the options are, and how they are used.

* Tests are now scoped with their directory name, which should
  avoid possible name collisions with test names.

* A number of tests have been either moved or incorporated into
  the newer testutil/acutest framework.  We are moving away from
  my old c-convey framework to something easier to debug.

* We use CMake directories a bit more extensively leading to a much
  cleaner CMake structure.  It's not complete, but a big step in the
  right direction, and a preview of future work.

* Tests are now run with verbose flags, so we get more test results
  in the CI/CD logs.

1 files changed, 199 insertions, 0 deletions

diff --git a/src/platform/resolver_test.c b/src/platform/resolver_test.c
new file mode 100644
index 00000000..43168cdb
--- /dev/null
+++ b/src/platform/resolver_test.c
@@ -0,0 +1,199 @@
+//
+// Copyright 2020 Staysail Systems, Inc. <info@staysail.tech>
+// Copyright 2018 Capitar IT Group BV <info@capitar.com>
+//
+// This software is supplied under the terms of the MIT License, a
+// copy of which should be located in the distribution where this
+// file was obtained (LICENSE.txt).  A copy of the license may also be
+// found online at https://opensource.org/licenses/MIT.
+//
+
+#include "testutil.h"
+
+#include <string.h>
+
+#include "core/nng_impl.h"
+#include "stubs.h"
+
+#include "acutest.h"
+
+#ifndef _WIN32
+#include <arpa/inet.h> // for htons, htonl
+#endif
+
+uint8_t v6loop[16] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1 };
+
+void
+test_google_dns(void)
+{
+	nng_aio *    aio;
+	nng_sockaddr sa;
+
+	TEST_NNG_PASS(nng_aio_alloc(&aio, NULL, NULL));
+	nni_resolv_ip("google-public-dns-a.google.com", "80", NNG_AF_INET,
+	    true, &sa, aio);
+	nng_aio_wait(aio);
+	TEST_NNG_PASS(nng_aio_result(aio));
+	TEST_CHECK(sa.s_in.sa_family == NNG_AF_INET);
+	TEST_CHECK(sa.s_in.sa_port == ntohs(80));
+	TEST_CHECK(sa.s_in.sa_addr == 0x08080808); // aka 8.8.8.8
+	nng_aio_free(aio);
+}
+
+void
+test_numeric_addr(void)
+{
+	nng_aio *    aio;
+	nng_sockaddr sa;
+
+	TEST_NNG_PASS(nng_aio_alloc(&aio, NULL, NULL));
+	nni_resolv_ip("8.8.4.4", "69", NNG_AF_INET, true, &sa, aio);
+	nng_aio_wait(aio);
+	TEST_NNG_PASS(nng_aio_result(aio));
+	TEST_CHECK(sa.s_in.sa_family == NNG_AF_INET);
+	TEST_CHECK(sa.s_in.sa_port == ntohs(69));
+	TEST_CHECK(sa.s_in.sa_addr == ntohl(0x08080404)); // 8.8.4.4.
+	nng_aio_free(aio);
+}
+
+void
+test_numeric_v6(void)
+{
+	nng_aio *    aio;
+	nng_sockaddr sa;
+
+	// Travis CI has moved some of their services to host that
+	// apparently don't support IPv6 at all.  This is very sad.
+	// CircleCI 2.0 is in the same boat.  (Amazon to blame.)
+	if ((getenv("TRAVIS") != NULL) || (getenv("CIRCLECI") != NULL)) {
+		return; // skip this one.
+	}
+
+	TEST_NNG_PASS(nng_aio_alloc(&aio, NULL, NULL));
+	nni_resolv_ip("::1", "80", NNG_AF_INET6, true, &sa, aio);
+	nng_aio_wait(aio);
+	TEST_NNG_PASS(nng_aio_result(aio));
+	TEST_CHECK(sa.s_in6.sa_family == NNG_AF_INET6);
+	TEST_CHECK(sa.s_in6.sa_port == ntohs(80));
+	TEST_CHECK(memcmp(sa.s_in6.sa_addr, v6loop, 16) == 0);
+	nng_aio_free(aio);
+}
+
+void
+test_service_names(void)
+{
+	nng_aio *    aio;
+	nng_sockaddr sa;
+
+	TEST_NNG_PASS(nng_aio_alloc(&aio, NULL, NULL));
+	nni_resolv_ip("8.8.4.4", "http", NNG_AF_INET, true, &sa, aio);
+	nng_aio_wait(aio);
+	TEST_NNG_PASS(nng_aio_result(aio));
+	TEST_CHECK(sa.s_in.sa_port == ntohs(80));
+	TEST_CHECK(sa.s_in.sa_addr = ntohl(0x08080404));
+	nng_aio_free(aio);
+}
+
+void
+test_localhost_v4(void)
+{
+	nng_aio *    aio;
+	nng_sockaddr sa;
+
+	TEST_NNG_PASS(nng_aio_alloc(&aio, NULL, NULL));
+	nni_resolv_ip("localhost", "80", NNG_AF_INET, true, &sa, aio);
+	nng_aio_wait(aio);
+	TEST_NNG_PASS(nng_aio_result(aio));
+	TEST_CHECK(sa.s_in.sa_family == NNG_AF_INET);
+	TEST_CHECK(sa.s_in.sa_port == ntohs(80));
+	TEST_CHECK(sa.s_in.sa_addr == ntohl(0x7f000001));
+	nng_aio_free(aio);
+}
+
+void
+test_localhost_unspec(void)
+{
+	nng_aio *    aio;
+	nng_sockaddr sa;
+
+	TEST_NNG_PASS(nng_aio_alloc(&aio, NULL, NULL));
+	nni_resolv_ip("localhost", "80", NNG_AF_UNSPEC, true, &sa, aio);
+	nng_aio_wait(aio);
+	TEST_NNG_PASS(nng_aio_result(aio));
+	TEST_CHECK(
+	    (sa.s_family == NNG_AF_INET) || (sa.s_family == NNG_AF_INET6));
+	switch (sa.s_family) {
+	case NNG_AF_INET:
+		TEST_CHECK(sa.s_in.sa_port == ntohs(80));
+		TEST_CHECK(sa.s_in.sa_addr == ntohl(0x7f000001));
+		break;
+	case NNG_AF_INET6:
+		TEST_CHECK(sa.s_in6.sa_port == ntohs(80));
+		TEST_CHECK(memcmp(sa.s_in6.sa_addr, v6loop, 16) == 0);
+		break;
+	}
+	nng_aio_free(aio);
+}
+
+void
+test_null_passive(void)
+{
+	nng_aio *    aio;
+	nng_sockaddr sa;
+
+	TEST_NNG_PASS(nng_aio_alloc(&aio, NULL, NULL));
+	nni_resolv_ip(NULL, "80", NNG_AF_INET, true, &sa, aio);
+	nng_aio_wait(aio);
+	TEST_NNG_PASS(nng_aio_result(aio));
+	TEST_CHECK(sa.s_in.sa_family == NNG_AF_INET);
+	TEST_CHECK(sa.s_in.sa_port == ntohs(80));
+	TEST_CHECK(sa.s_in.sa_addr == 0); // INADDR_ANY
+	nng_aio_free(aio);
+}
+
+void
+test_null_not_passive(void)
+{
+	nng_aio *    aio;
+	nng_sockaddr sa;
+
+	TEST_NNG_PASS(nng_aio_alloc(&aio, NULL, NULL));
+	nni_resolv_ip(NULL, "80", NNG_AF_INET, false, &sa, aio);
+	nng_aio_wait(aio);
+	// We can either get NNG_EADDRINVAL, or a loopback address.
+	// Most systems do the former, but Linux does the latter.
+	if (nng_aio_result(aio) == 0) {
+		TEST_CHECK(sa.s_family == NNG_AF_INET);
+		TEST_CHECK(sa.s_in.sa_addr == htonl(0x7f000001));
+		TEST_CHECK(sa.s_in.sa_port == htons(80));
+	} else {
+		TEST_NNG_FAIL(nng_aio_result(aio), NNG_EADDRINVAL);
+	}
+	nng_aio_free(aio);
+}
+
+void
+test_bad_port_number(void)
+{
+	nng_aio *    aio;
+	nng_sockaddr sa;
+
+	TEST_NNG_PASS(nng_aio_alloc(&aio, NULL, NULL));
+	nni_resolv_ip("1.1.1.1", "1000000", NNG_AF_INET, true, &sa, aio);
+	nng_aio_wait(aio);
+	TEST_NNG_FAIL(nng_aio_result(aio), NNG_EADDRINVAL);
+	nng_aio_free(aio);
+}
+
+TEST_LIST = {
+	{ "resolve google dns", test_google_dns },
+	{ "resolve numeric addr", test_numeric_addr },
+	{ "resolve numeric v6", test_numeric_v6 },
+	{ "resolve service names", test_service_names },
+	{ "resolve localhost v4", test_localhost_v4 },
+	{ "resolve localhost unspec", test_localhost_unspec },
+	{ "resolve null passive", test_null_passive },
+	{ "resolve null not passive", test_null_not_passive },
+	{ "resolve bad port number", test_bad_port_number },
+	{ NULL, NULL },
+};