diff options
| author | Garrett D'Amore <garrett@damore.org> | 2024-12-26 14:32:34 -0800 |
|---|---|---|
| committer | Garrett D'Amore <garrett@damore.org> | 2024-12-26 15:57:48 -0800 |
| commit | c8b58f9128dd1e4b9424d79d22f5ae50a8bff54a (patch) | |
| tree | 73d1d368a67cce45eec797704f85d9e3545ef93b /src/platform/windows | |
| parent | 1ad7f88e0c58285c9e1cad9448d5a1fcfa7a07f1 (diff) | |
| download | nng-c8b58f9128dd1e4b9424d79d22f5ae50a8bff54a.tar.gz nng-c8b58f9128dd1e4b9424d79d22f5ae50a8bff54a.tar.bz2 nng-c8b58f9128dd1e4b9424d79d22f5ae50a8bff54a.zip | |
udp: use nni_aio_start
This also moves the close of the UDP socket later, to avoid a
potential use after free while the aio's are still in-flight.
Unfortunately we cannot unbind cleanly without a hard close.
Diffstat (limited to 'src/platform/windows')
| -rw-r--r-- | src/platform/windows/win_udp.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/src/platform/windows/win_udp.c b/src/platform/windows/win_udp.c index c1c7ef21..c74b3f77 100644 --- a/src/platform/windows/win_udp.c +++ b/src/platform/windows/win_udp.c @@ -122,9 +122,7 @@ nni_plat_udp_send(nni_plat_udp *u, nni_aio *aio) int rv; DWORD nsent; - if (nni_aio_begin(aio) != 0) { - return; - } + nni_aio_reset(aio); sa = nni_aio_get_input(aio, 0); if ((tolen = nni_win_nn2sockaddr(&to, sa)) < 0) { nni_aio_finish_error(aio, NNG_EADDRINVAL); @@ -280,19 +278,15 @@ again: void nni_plat_udp_recv(nni_plat_udp *u, nni_aio *aio) { - int rv; - if (nni_aio_begin(aio) != 0) { - return; - } + nni_aio_reset(aio); nni_mtx_lock(&u->lk); if (u->closed) { nni_mtx_unlock(&u->lk); nni_aio_finish_error(aio, NNG_ECLOSED); return; } - if ((rv = nni_aio_schedule(aio, udp_recv_cancel, u)) != 0) { + if (!nni_aio_start(aio, udp_recv_cancel, u)) { nni_mtx_unlock(&u->lk); - nni_aio_finish_error(aio, rv); return; } nni_list_append(&u->rxq, aio); |