fixes #1032 Figure out Darwin bustedness

fixes #1035 Convey is awkward -- consider acutest.h

This represents a rather large effort towards cleaning up our
testing and optional configuration infrastructure.

A separate test library is built by default, which is static, and
includes some useful utilities design to make it easier to write
shorter and more robust (not timing dependent) tests.  This also means
that we can cover pretty nearly all the tests (protocols etc.) in
every case, even if the shipped image will be minimized.

Subsystems which are optional can now use a few new macros to configure
what they need see nng_sources_if, nng_headers_if, and nng_defines_if.
This goes a long way to making the distributed CMakefiles a lot simpler.

Additionally, tests for different parts of the tree can now be located
outside of the tests/ tree, so that they can be placed next to the code
that they are testing.

Beyond the enabling work, the work has only begun, but these changes
have resolved the most often failing tests for Darwin in the cloud.

2 files changed, 75 insertions, 7 deletions

diff --git a/src/supplemental/sha1/CMakeLists.txt b/src/supplemental/sha1/CMakeLists.txt
index 370dc7c2..de301b08 100644
--- a/src/supplemental/sha1/CMakeLists.txt
+++ b/src/supplemental/sha1/CMakeLists.txt
@@ -1,6 +1,6 @@
 #
+# Copyright 2019 Staysail Systems, Inc. <info@staysail.tech>
 # Copyright 2017 Capitar IT Group BV <info@capitar.com>
-# Copyright 2018 Staysail Systems, Inc. <info@staysail.tech>
 #
 # This software is supplied under the terms of the MIT License, a
 # copy of which should be located in the distribution where this
@@ -8,9 +8,5 @@
 # found online at https://opensource.org/licenses/MIT.
 #
 
-if (NNG_SUPP_SHA1)
-        set(_SRCS
-                supplemental/sha1/sha1.c
-                supplemental/sha1/sha1.h)
-        set(NNG_SRCS ${NNG_SRCS} ${_SRCS} PARENT_SCOPE)
-endif()
+nng_sources_if(NNG_SUPP_SHA1 sha1.c sha1.h)
+nng_test(sha1_test)
diff --git a/src/supplemental/sha1/sha1_test.c b/src/supplemental/sha1/sha1_test.c
new file mode 100644
index 00000000..505175b0
--- /dev/null
+++ b/src/supplemental/sha1/sha1_test.c
@@ -0,0 +1,72 @@
+//
+// Copyright 2019 Staysail Systems, Inc. <info@staysail.tech>
+// Copyright 2018 Capitar IT Group BV <info@capitar.com>
+//
+// This software is supplied under the terms of the MIT License, a
+// copy of which should be located in the distribution where this
+// file was obtained (LICENSE.txt).  A copy of the license may also be
+// found online at https://opensource.org/licenses/MIT.
+//
+
+#include <stdint.h>
+#include <string.h>
+
+#include <nng/nng.h>
+
+#include <acutest.h>
+
+#include "sha1.h"
+
+
+// The following test vectors are from RFC 3174.
+#define TEST1 "abc"
+#define TEST2a "abcdbcdecdefdefgefghfghighijhi"
+#define TEST2b "jkijkljklmklmnlmnomnopnopq"
+#define TEST2 TEST2a TEST2b
+#define TEST3 "a"
+#define TEST4a "01234567012345670123456701234567"
+#define TEST4b "01234567012345670123456701234567"
+/* an exact multiple of 512 bits */
+#define TEST4 TEST4a TEST4b
+
+char *testarray[4]   = { TEST1, TEST2, TEST3, TEST4 };
+int   repeatcount[4] = { 1, 1, 1000000, 10 };
+char *resultarray[4] = {
+	"A9 99 3E 36 47 06 81 6A BA 3E 25 71 78 50 C2 6C 9C D0 D8 9D",
+	"84 98 3E 44 1C 3B D2 6E BA AE 4A A1 F9 51 29 E5 E5 46 70 F1",
+	"34 AA 97 3C D4 C4 DA A4 F6 1E EB 2B DB AD 27 31 65 34 01 6F",
+	"DE A3 56 A2 CD DD 90 C7 A7 EC ED C5 EB B5 63 93 4F 46 04 52"
+};
+
+void
+test_sha1(void)
+{
+
+	for (int i = 0; i < 4; i++) {
+		nni_sha1_ctx ctx;
+		size_t       slen = strlen(testarray[i]);
+		uint8_t      digest[20];
+		char         strout[20 * 3 + 1];
+		char         name[8];
+
+		snprintf(name, sizeof(name), "%d", i);
+		TEST_CASE(name);
+
+		memset(digest, 0, sizeof(digest));
+		nni_sha1_init(&ctx);
+		for (int j = 0; j < repeatcount[i]; j++) {
+			nni_sha1_update(&ctx, (uint8_t *) testarray[i], slen);
+		}
+		nni_sha1_final(&ctx, digest);
+		for (int j = 0; j < 20; j++) {
+			snprintf(strout + j * 3, 4, "%02X ", digest[j]);
+		}
+		strout[20 * 3 - 1] = '\0';
+		TEST_CHECK(strcmp(strout, resultarray[i]) == 0);
+	}
+}
+
+TEST_LIST = {
+	{ "sha1", test_sha1 },
+	{ NULL, NULL },
+};