fixes #396 illumos doesn't build (missing NNG_PLATFORM_POSIX ON)

fixes #397 Need to cast zoneid
fixes #395 sun is predefined on illumos/Solaris
fixes #394 alloca needs to #include <alloca.h>
fixes #399 Cannot use SVR4.2 specific msghdr
fixes #402 getpeerucred needs a NULL initialized ucred
fixes #403 syntax error in posix_tcp - attempt to return void
fixes #407 illumos getegid wrong
fixes #406 nni_idhash_count is dead code
fixes #404 idhash typedef redeclared
fixes #405 warning: newline not last character in file

This is basically a slew of related bug fixes required to make this
work on illumos.  Note that the fixes are not "complete", because
more work is required to support port events given that epoll is busted
on illumos.

We also fixed a bunch of things that aren't actually "bugs" per se, but
really just warnings.  Silencing them makes things better for everyone.
Apparently not all compilers are equally happy with redundant (but
otherwise identical) typedefs; we use structs in some places instead of
shorter type names to silence these complaints.

Note that IPC permissions (the mode bits on the socket vnode) are not
validated on SunOS systems.  This change includes documentation to reflect
that.

1 files changed, 0 insertions, 6 deletions

diff --git a/src/supplemental/util/platform.c b/src/supplemental/util/platform.c
index ce52491a..fc0f839e 100644
--- a/src/supplemental/util/platform.c
+++ b/src/supplemental/util/platform.c
@@ -29,10 +29,6 @@ nng_msleep(nng_duration dur)
 	nni_msleep(dur);
 }
 
-// nng_thread is a handle to a "thread", which may be a real system
-// thread, or a coroutine on some platforms.
-typedef struct nng_thread nng_thread;
-
 // Create and start a thread.  Note that on some platforms, this might
 // actually be a coroutine, with limitations about what system APIs
 // you can call.  Therefore, these threads should only be used with the
@@ -111,8 +107,6 @@ struct nng_cv {
 	nni_cv c;
 };
 
-typedef struct nng_cv nng_cv;
-
 int
 nng_cv_alloc(nng_cv **cvp, nng_mtx *mx)
 {