aboutsummaryrefslogtreecommitdiff
path: root/src/core
diff options
context:
space:
mode:
Diffstat (limited to 'src/core')
-rw-r--r--src/core/device.c15
-rw-r--r--src/core/sock_test.c13
-rw-r--r--src/core/socket.c17
-rw-r--r--src/core/socket.h3
4 files changed, 11 insertions, 37 deletions
diff --git a/src/core/device.c b/src/core/device.c
index 08c7bab5..7a6fb479 100644
--- a/src/core/device.c
+++ b/src/core/device.c
@@ -1,5 +1,5 @@
//
-// Copyright 2021 Staysail Systems, Inc. <info@staysail.com>
+// Copyright 2024 Staysail Systems, Inc. <info@staysail.com>
// Copyright 2018 Capitar IT Group BV <info@capitar.com>
//
// This software is supplied under the terms of the MIT License, a
@@ -128,8 +128,6 @@ device_init(device_data **dp, nni_sock *s1, nni_sock *s2)
{
int num_paths = 2;
int i;
- bool raw;
- size_t rsz;
device_data *d;
// Specifying either of these as null turns the device into
@@ -149,18 +147,11 @@ device_init(device_data **dp, nni_sock *s1, nni_sock *s2)
return (NNG_EINVAL);
}
- raw = false;
- rsz = sizeof(raw);
- if (((nni_sock_getopt(s1, NNG_OPT_RAW, &raw, &rsz, NNI_TYPE_BOOL) !=
- 0)) ||
- (!raw)) {
+ if (!nni_sock_raw(s1)) {
return (NNG_EINVAL);
}
- rsz = sizeof(raw);
- if (((nni_sock_getopt(s2, NNG_OPT_RAW, &raw, &rsz, NNI_TYPE_BOOL) !=
- 0)) ||
- (!raw)) {
+ if (!nni_sock_raw(s2)) {
return (NNG_EINVAL);
}
diff --git a/src/core/sock_test.c b/src/core/sock_test.c
index 7641ea1f..5981a2e3 100644
--- a/src/core/sock_test.c
+++ b/src/core/sock_test.c
@@ -314,7 +314,6 @@ test_endpoint_types(void)
nng_dialer d2;
nng_listener l2;
char *a = "inproc://mumble...";
- bool b;
NUTS_OPEN(s1);
@@ -324,7 +323,6 @@ test_endpoint_types(void)
// Forge a listener
l2.id = nng_dialer_id(d);
- NUTS_FAIL(nng_listener_get_bool(l2, NNG_OPT_RAW, &b), NNG_ENOENT);
NUTS_FAIL(nng_listener_close(l2), NNG_ENOENT);
NUTS_PASS(nng_dialer_close(d));
@@ -334,7 +332,6 @@ test_endpoint_types(void)
// Forge a dialer
d2.id = nng_listener_id(l);
- NUTS_FAIL(nng_dialer_get_bool(d2, NNG_OPT_RAW, &b), NNG_ENOENT);
NUTS_FAIL(nng_dialer_close(d2), NNG_ENOENT);
NUTS_PASS(nng_listener_close(l));
@@ -405,7 +402,6 @@ test_listener_options(void)
NUTS_FAIL(
nng_listener_set_string(l, NNG_OPT_SOCKNAME, "1"), NNG_ENOTSUP);
- NUTS_FAIL(nng_listener_set_bool(l, NNG_OPT_RAW, true), NNG_ENOTSUP);
NUTS_FAIL(nng_listener_set_ms(l, NNG_OPT_RECONNMINT, 1), NNG_ENOTSUP);
NUTS_FAIL(nng_listener_set_string(l, NNG_OPT_SOCKNAME, "bogus"),
NNG_ENOTSUP);
@@ -440,7 +436,6 @@ test_dialer_options(void)
// Cannot set inappropriate options
NUTS_FAIL(
nng_dialer_set_string(d, NNG_OPT_SOCKNAME, "1"), NNG_ENOTSUP);
- NUTS_FAIL(nng_dialer_set_bool(d, NNG_OPT_RAW, true), NNG_ENOTSUP);
NUTS_FAIL(nng_dialer_set_ms(d, NNG_OPT_SENDTIMEO, 1), NNG_ENOTSUP);
NUTS_FAIL(
nng_dialer_set_string(d, NNG_OPT_SOCKNAME, "bogus"), NNG_ENOTSUP);
@@ -456,9 +451,7 @@ void
test_endpoint_absent_options(void)
{
size_t s;
- int i;
nng_duration t;
- bool b;
nng_dialer d;
nng_listener l;
d.id = 1999;
@@ -467,15 +460,9 @@ test_endpoint_absent_options(void)
NUTS_FAIL(nng_dialer_set_size(d, NNG_OPT_RECVMAXSZ, 10), NNG_ENOENT);
NUTS_FAIL(nng_listener_set_size(l, NNG_OPT_RECVMAXSZ, 10), NNG_ENOENT);
- NUTS_FAIL(nng_dialer_get_bool(d, NNG_OPT_RAW, &b), NNG_ENOENT);
- NUTS_FAIL(nng_listener_get_bool(l, NNG_OPT_RAW, &b), NNG_ENOENT);
-
NUTS_FAIL(nng_dialer_get_size(d, NNG_OPT_RECVMAXSZ, &s), NNG_ENOENT);
NUTS_FAIL(nng_listener_get_size(l, NNG_OPT_RECVMAXSZ, &s), NNG_ENOENT);
- NUTS_FAIL(nng_dialer_get_int(d, NNG_OPT_RAW, &i), NNG_ENOENT);
- NUTS_FAIL(nng_listener_get_int(l, NNG_OPT_RAW, &i), NNG_ENOENT);
-
NUTS_FAIL(nng_dialer_get_ms(d, NNG_OPT_RECVTIMEO, &t), NNG_ENOENT);
NUTS_FAIL(nng_listener_get_ms(l, NNG_OPT_SENDTIMEO, &t), NNG_ENOENT);
}
diff --git a/src/core/socket.c b/src/core/socket.c
index 0e9b6b17..b01938e5 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -137,13 +137,6 @@ sock_get_fd(nni_sock *s, unsigned flag, int *fdp)
}
static int
-sock_get_raw(void *s, void *buf, size_t *szp, nni_type t)
-{
- bool raw = ((nni_sock_flags(SOCK(s)) & NNI_PROTO_FLAG_RAW) != 0);
- return (nni_copyout_bool(raw, buf, szp, t));
-}
-
-static int
sock_set_recvtimeo(void *s, const void *buf, size_t sz, nni_type t)
{
return (nni_copyin_ms(&SOCK(s)->s_rcvtimeo, buf, sz, t));
@@ -253,10 +246,6 @@ static const nni_option sock_options[] = {
.o_get = sock_get_sockname,
.o_set = sock_set_sockname,
},
- {
- .o_name = NNG_OPT_RAW,
- .o_get = sock_get_raw,
- },
// terminate list
{
.o_name = NULL,
@@ -823,6 +812,12 @@ nni_sock_peer_name(nni_sock *sock)
return (sock->s_peer_id.p_name);
}
+bool
+nni_sock_raw(nni_sock *sock)
+{
+ return ((nni_sock_flags(sock) & NNI_PROTO_FLAG_RAW) != 0);
+}
+
struct nni_proto_pipe_ops *
nni_sock_proto_pipe_ops(nni_sock *sock)
{
diff --git a/src/core/socket.h b/src/core/socket.h
index 714ad5bb..8fab08d6 100644
--- a/src/core/socket.h
+++ b/src/core/socket.h
@@ -1,5 +1,5 @@
//
-// Copyright 2021 Staysail Systems, Inc. <info@staysail.tech>
+// Copyright 2024 Staysail Systems, Inc. <info@staysail.tech>
// Copyright 2018 Capitar IT Group BV <info@capitar.com>
//
// This software is supplied under the terms of the MIT License, a
@@ -22,6 +22,7 @@ extern uint16_t nni_sock_proto_id(nni_sock *);
extern uint16_t nni_sock_peer_id(nni_sock *);
extern const char *nni_sock_proto_name(nni_sock *);
extern const char *nni_sock_peer_name(nni_sock *);
+extern bool nni_sock_raw(nni_sock *);
extern void *nni_sock_proto_data(nni_sock *);
extern void nni_sock_add_stat(nni_sock *, nni_stat_item *);
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2026-01-18 16:25:19 +0000