diff options
| author | Garrett D'Amore <garrett@damore.org> | 2024-12-07 19:32:40 -0800 |
|---|---|---|
| committer | Garrett D'Amore <garrett@damore.org> | 2024-12-07 19:39:38 -0800 |
| commit | 3ca7bcc0edd0f26c33264d32e7b6f07276e72e3c (patch) | |
| tree | 99b7a80b4c7241c030e0ee4e1b08f3d515f1db3f /src/core/taskq.h | |
| parent | 8af6befd3a3805501e5c13612558241e60b349ba (diff) | |
| download | nng-3ca7bcc0edd0f26c33264d32e7b6f07276e72e3c.tar.gz nng-3ca7bcc0edd0f26c33264d32e7b6f07276e72e3c.tar.bz2 nng-3ca7bcc0edd0f26c33264d32e7b6f07276e72e3c.zip | |
aio: task_abort was a mistake
The use of task_abort to prematurely fail an aio at scheduling
time was a mistake, because it could have led to duplicate calls
to nng_aio_finish(). We do need to ensure that we leave an indicator
so that nni_aio_schedule can return the abort status to caller,
in the case that abort is called between the nni_aio_begin and
nni_aio_schedule calls.
Diffstat (limited to 'src/core/taskq.h')
| -rw-r--r-- | src/core/taskq.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/core/taskq.h b/src/core/taskq.h index d3299433..356ef725 100644 --- a/src/core/taskq.h +++ b/src/core/taskq.h @@ -40,11 +40,6 @@ extern void nni_task_exec(nni_task *); // nni_task_exec). extern void nni_task_prep(nni_task *); -// nni_task_abort is called to undo the effect of nni_task_prep, -// basically. The aio framework uses this when nni_aio_schedule() -// returns an error. -extern void nni_task_abort(nni_task *); - // nni_task_busy checks to see if a task is still busy. // This is uses the same check that nni_task_wait uses. extern bool nni_task_busy(nni_task *); |